Fix ZStream#debounce interruption issue #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I think only the |
|
Done |
|
I will change |
|
Done |
|
@iravid this is ready for review |
iravid
reviewed
Jun 8, 2020
Comment on lines
2737
to
2743
| }.onInterrupt( | ||
| ref.get.flatMap { | ||
| case Previous(fiber) => fiber.interrupt | ||
| case Current(fiber) => fiber.interrupt | ||
| case _ => ZIO.unit | ||
| } | ||
| ) |
There was a problem hiding this comment.
Sorry for this PR dragging out. It's probably better for this finalizer to be attached to the construction of the Ref; this way the fiber is interrupted even if the stream is interrupted "in-between" pulls. What do you think?
There was a problem hiding this comment.
@iravid I think you mean:
Ref.make[State](NotStarted).toManaged {
_.get.flatMap {
case Previous(fiber) => fiber.interrupt
case Current(fiber) => fiber.interrupt
case _ => ZIO.unit
}
}Don't you?
There was a problem hiding this comment.
@iravid makes sense, done. Also added a new test case for the fiber interruption.
iravid
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3740