Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Most Specific Collection Type With Chunk #3855

Merged
merged 2 commits into from Jun 29, 2020
Merged

Return Most Specific Collection Type With Chunk #3855

merged 2 commits into from Jun 29, 2020

Conversation

adamgfraser
Copy link
Contributor

Resolves #3849.

Improves integration with Scala collections library so we dynamically return Chunk as the concrete type even if it is upcast in an example like:

"pre1" +: (zio.Chunk("foo"): Seq[String])

@adamgfraser adamgfraser merged commit 069d7b8 into zio:master Jun 29, 2020
@adamgfraser adamgfraser deleted the prepend branch June 29, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

@iravid iravid Awaiting requested review from iravid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seq.+: is broken for Chunk on Scala 2.12
2 participants
@adamgfraser @jdegoes