Implement ZTransducer.foldUntil using ZTransducer.fold #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used foldWeighted, which prevented transducers based on it (like collectAllN) from emitting immediately when N elements were accumulated.
|
@simpadjo appreciate your review here |
adamgfraser
approved these changes
Jun 26, 2020
simpadjo
reviewed
Jun 26, 2020
| @@ -74,6 +74,11 @@ object ZTransducerSpec extends ZIOBaseSpec { | |||
| }, | |||
| testM("doesn't emit empty trailing chunks") { | |||
| assertM(run(ZTransducer.collectAllN[Int](3), List(Chunk(1, 2, 3))))(equalTo(Chunk(List(1, 2, 3)))) | |||
| }, | |||
| testM("emits chunks when exactly N elements received") { | |||
There was a problem hiding this comment.
The test could be blackboxified: something like
(ZStream(1,2,3,4) ++ ZStream.fromEffect(ZIO.never)).transduce(t).take(1)
There was a problem hiding this comment.
Thanks! I actually prefer to test the transducer directly in this case as it is a bit of an edge case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used foldWeighted, which prevented
transducers based on it (like collectAllN) from emitting immediately
when N elements were accumulated.
Resolves #3860.