Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OOM at bufferSliding #3892

Merged
merged 1 commit into from Jun 30, 2020
Merged

Fix OOM at bufferSliding #3892

merged 1 commit into from Jun 30, 2020

Conversation

narma
Copy link
Contributor

@narma narma commented Jun 27, 2020

Fix #3882

@narma narma requested a review from iravid as a code owner June 27, 2020 13:10
@narma
Copy link
Contributor Author

narma commented Jun 27, 2020 •
edited

I think to make separate PR with memory leaks tests, @iravid what do you think? Also question, they should be part of all tests or placed separately like benchmarks?

@narma
Copy link
Contributor Author

narma commented Jun 27, 2020

With that fix
jvm args: -Xmx2048M -Xms512M -XX:+UseG1GC
program:

 ZStream
      .repeat(Foo(1L))
      .bufferSliding(1)
      .runDrain
      .exitCode

изображение

@iravid iravid merged commit 68fefa7 into zio:master Jun 30, 2020
@narma narma deleted the buffer-sliding-oom-fix branch July 1, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iravid iravid iravid approved these changes

@adamgfraser adamgfraser adamgfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OOM using bufferSliding
3 participants
@narma @iravid @adamgfraser