Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ZHub A Sealed Abstract Class For Improved Binary Compatibility #4925

Merged
merged 1 commit into from
Apr 9, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/shared/src/main/scala/zio/ZHub.scala
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import java.util.concurrent.atomic.AtomicBoolean
* messages can require an environment of type `RB` and fail with an error of
* type `EB`.
*/
sealed trait ZHub[-RA, -RB, +EA, +EB, -A, +B] extends Serializable { self =>
sealed abstract class ZHub[-RA, -RB, +EA, +EB, -A, +B] extends Serializable { self =>

/**
* Waits for the hub to be shut down.
Expand Down Expand Up @@ -438,7 +438,7 @@ object ZHub {
* A `Strategy[A]` describes the protocol for how publishers and subscribers
* will communicate with each other through the hub.
*/
private trait Strategy[A] {
private sealed abstract class Strategy[A] {

/**
* Describes how publishers should signal to subscribers that they are
Expand Down