Fix Gen.instant when upper and lower bound second part are the same 1.x #7325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strokyl
force-pushed
the
fix_gen_instant
branch
from
2a314d3
to
c2146f8
Compare
strokyl
commented
Sep 8, 2022
| @@ -0,0 +1,30 @@ | |||
| package zio.test | |||
There was a problem hiding this comment.
I am pretty sure I am not suppose to put this test here.
Can you tell me where to put it?
There was a problem hiding this comment.
I think you are looking for GenSpec.scala.
adamgfraser
previously approved these changes
Sep 8, 2022
strokyl
force-pushed
the
fix_gen_instant
branch
from
c2146f8
to
0f309c7
Compare
Done and I almost move my test to GenSpec |
strokyl
changed the title
adamgfraser
approved these changes
Sep 9, 2022
adamgfraser
pushed a commit
that referenced
this pull request
Oct 17, 2022
* Fix Gen.instant (#7325) * Make concatenation of empty chunks 600 times faster (#7396) * Extend benchmark coverage of Chunk concatenation * Improve performance of concatenation of empty Chunks * replace unused identifier with _ * Improve Chunk concatenation performance when either chunk is empty. (#7399) * Update things for Scala Native (still no running tests) (#7409) * Scala Native: run tests * Native: Run scala-native-loop in OneShot#get * Native: Test / fork := false * ci.yaml: testPlatforms on Scala 3 * ci.yaml: testPlatforms 180 min timeout * ci.yaml: testPlatforms 360 min timeout * ci.yaml: testPlatforms on Scala 3 * Update versions * Update versions * Update munit * Update things for Scala Native (still no running tests) * Update * Scala 2.12.16, 2.13.8 * fix merge Co-authored-by: LUC DUZAN <strokyl@users.noreply.github.com> Co-authored-by: Rafał Sumisławski <rafal.sumislawski@gmail.com> Co-authored-by: shawjef3 <shawjef3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.