Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Izumi Reflect Version #7490

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Upgrade Izumi Reflect Version #7490

merged 1 commit into from
Nov 2, 2022

Conversation

adamgfraser
Copy link
Contributor

Resolves #7489.

@narma
Copy link
Contributor

narma commented Nov 1, 2022

Not sure it really helps. Have tested with izumi-reflect 2.2.1 - still fails.

@adamgfraser
Copy link
Contributor Author

I think you may need to override the dependency version. I was able to replicate your issue with izumi-reflect-2.2.0 but not with changing the ZIO dependency to izumi-reflect-2.1.3 or izumi-reflect-2.2.1.

@narma
Copy link
Contributor

narma commented Nov 2, 2022

Hm, have tested it in 3 ways, all unsuccessfully.

First with scala-cli snippet.

//> using scala "3.2.0"
//> using lib "dev.zio::zio:2.0.3"
//> using lib "dev.zio::izumi-reflect:2.2.1"
//> using lib "dev.zio::zio-metrics-prometheus:2.0.0"

Second with

dependencyOverrides ++= Seq(
      "dev.zio" %% "izumi-reflect" % "2.2.1"
    ),

Third with rebuild zio with these changes locally and set this version in project.

@jdegoes jdegoes merged commit c40fb7d into zio:series/2.x Nov 2, 2022
@adamgfraser adamgfraser deleted the 7489 branch November 3, 2022 08:56
@celetium
Copy link

celetium commented Dec 1, 2022

I tried:
zio 2.0.3 with izumi-reflect 2.2.0 ... and
zio 2.0.4 with izumi-refect 2.2.1, both are UNSUCCESSFUL.
zio 2.0.0-2 with refect 2.1.3, are OK.

@neko-kai
Copy link
Member

neko-kai commented Dec 1, 2022

I suspect recompiling zio with newest reflect 2.2.2 will fix that. @adamgfraser @celetium - this looks like breakage from compatibility change in scala 3 prefix hanling int2.2.0 - https://github.com/zio/izumi-reflect/releases/tag/v2.2.0 - and there's another fix to prefixes in 2.2.2. so you want to update to that instead. https://github.com/zio/izumi-reflect/releases/tag/v2.2.2

@adamgfraser
Copy link
Contributor Author

@neko-kai Thanks! Just submitted a PR to upgrade to the latest izumi-reflect version.

@celetium You need to upgrade to the latest version of zio-metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defect: Could not find service in ZEnvironment with scala 3
5 participants