Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignoreLogged does not log fix #7515

Merged
merged 3 commits into from
Nov 12, 2022
Merged

ignoreLogged does not log fix #7515

merged 3 commits into from
Nov 12, 2022

Conversation

piotrga
Copy link
Contributor

@piotrga piotrga commented Nov 11, 2022 •
edited
Loading

ignoreLogged is using foldCause but the parameter functions return ZIO so as the logging is never evaluated.

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

adamgfraser
adamgfraser previously approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@adamgfraser adamgfraser merged commit ace1fce into zio:series/2.x Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgfraser adamgfraser adamgfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piotrga @CLAassistant @adamgfraser