Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ZIO#logError #7593

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Implement ZIO#logError #7593

merged 4 commits into from
Dec 5, 2022

Conversation

adamgfraser
Copy link
Contributor

Resolves #7592.

jdegoes
jdegoes previously approved these changes Dec 2, 2022
View reviewed changes
@adamgfraser
Copy link
Contributor Author

Hmmm, looks like using the logErrorCause name for an operator on the ZIO trait causes a binary compatibility issue, at least according to MIMA. Perhaps we should rename logErrorCause to logError since the current logError inherently destroys information?

@jdegoes
Copy link
Member

jdegoes commented Dec 3, 2022

👍

@vigoo vigoo merged commit b533d4c into zio:series/2.x Dec 5, 2022
@adamgfraser adamgfraser deleted the 7592 branch December 6, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigoo vigoo vigoo approved these changes

@jdegoes jdegoes Awaiting requested review from jdegoes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ZIO#logError
3 participants
@adamgfraser @jdegoes @vigoo