Sbt bump 1.8.0 #7609
Merged
Sbt bump 1.8.0 #7609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been out for a month with no patches - see https://github.com/sbt/sbt/releases Compilation passes locally. Scalafix check passes locally.
|
|
|
@IdiosApps Hi! Can you sign the CLA? We haven't found that Dependabot made sense for us but happy to update the SBT version. |
Signed :) Sounds good 馃憤 |
|
Just to verify, the CI checks indeed ran with sbt 1.8.0: |
adamgfraser
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBT changes
A couple tangents I thought about when looking around the repo:
Dependabot
As a public repo, we should be able to add a Dependabot to
.github/dependabot.yaml. It could have a few benefits:I'd be happy to add that in another PR. You could try it, and disable if it's too noisy.
Windows
I thought at first the GH Action workflows were depending on sbt being baked into Ubuntu 20, and I was looking into using coursier's setup-action (as well as the cache action) to not have that point of weakness (GH's Ubuntu 22 image is missing sbt). I found out that the sbt file in root is sbt-extras, a wrapper around sbt. On Windows it's running compile/check nicely with https://git-scm.com/download/win. Doesn't look like there's a .bat version (thinking of gradlew/gradlew.bat). There might be docs around this already - I'll have a look another time. If not, this note here may help someone. It's at least good for super basic sbt commands as noted, and I don't seem to have WSL installed.
GitHub Action cache
I haven't used Coursier's cache action before, but I thought it would cache compilation/scalafix output.
I can see that code linting takes about 2 minutes:
Locally, my first
./sbt checktakes about 70 seconds, and I'm getting 4 seconds after that.Might there be some optimisations to compilation times & linting in CI if it can indeed cache the sbt cache of the build? As the tagline notes: