Honor TestArgs TestRenderer throughout zio-test machinery #7647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…everal places that are currently hardcoded to ConsoleRenderer
Add typed Renderer value to TestArgs. Check if this is a desirable change.
Struggling with this stupid <LOCATION> bit in my failure assertion.
swoogles
commented
Dec 20, 2022
| val sharedSinkLayer = sinkLayer(console, ConsoleEventRenderer) | ||
| val testArgs = TestArgs.parse(args) | ||
|
|
||
| renderer = testArgs.testRenderer // Ensures summary is pretty in same style as rest of the test output |
There was a problem hiding this comment.
@hmemcpy I think this obviates the need for TestArgs.printSummary, at least for some cases.
swoogles
commented
Dec 20, 2022
| @@ -74,19 +73,13 @@ abstract class ZIOSpecAbstract extends ZIOApp with ZIOSpecAbstractVersionSpecifi | |||
| testArgs = TestArgs.parse(args.getArgs.toArray) | |||
| summary <- runSpecAsApp(spec, testArgs, console) | |||
| _ <- ZIO.when(testArgs.printSummary) { | |||
There was a problem hiding this comment.
@hmemcpy I think we can remove this guard now, since we're always going to use the correct TestRenderer, and the IntellijTestRenderer will just be an empty string.
hmemcpy
approved these changes
Dec 20, 2022
adamgfraser
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some hard-coded
ConsoleRendererreferences that are now properTestRendererparameters.This should resolve #7241 by giving users the ability to specify which
TestRendererto use.Unrelated - Fixed timing of tests for the XML test reports.