ZIO Config: Don't Split Values Unless A Sequence Is Expected #7724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7716.
Currently if we have a config like
Config.string("greeting")
and a config provider likeConfigProvider.fromMap("greeting" -> "Hello, World!")
the result of loading this config will beHello
.While this has some internal logic to it since the
,
is a sequence delimiter and if a sequence isn't requested the first value will be returned, this also seems somewhat unexpected to me. Not only is the additional information in the value silently dropped but I also said I wanted to just load a string and not a sequence of strings.This PR changes that behavior so that now we only split a string if a sequence is requested. So loading
Config.chunkOf(Config.string("greeting"))
would returnChunk("Hello", "World!")
whereas loadingConfig.string("greeting")
would just load"Hello, World!"
.Unfortunately, this does require significant contortions in the implementation of
Flat
to support this while preserving binary compatibility since the current signature ofFlat#load
does not give the implementation enough information to know whether it is being requested to load a single value or a collection of values.