New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #771 RefM should permit errors #774

Merged

jdegoes merged 2 commits into zio:master from GodPlaysChess:refM-should-permit-errors-#771

Apr 21, 2019

Contributor

GodPlaysChess commented Apr 18, 2019 •

edited

This is the first part of it, which allows to update and modify with possibly failing effects.

In order to support the error type refined during computation
modify[R, E2 <: E, B](f: A => ZIO[R, E2, (B, A)]): ZIO[R, E2, B]

we need to make all the RefM chain (Bundle , Promise and State) covariant on E


          Fixes zio#771 RefM should permit errors

2e27814

jdegoes reviewed

View reviewed changes

core/shared/src/main/scala/scalaz/zio/RefM.scala Outdated Show resolved Hide resolved

jdegoes reviewed

View reviewed changes

core/shared/src/main/scala/scalaz/zio/RefM.scala Outdated Show resolved Hide resolved

jdegoes reviewed

View reviewed changes

core/shared/src/main/scala/scalaz/zio/RefM.scala Outdated Show resolved Hide resolved

jdegoes reviewed

View reviewed changes

core/shared/src/main/scala/scalaz/zio/RefM.scala Outdated Show resolved Hide resolved

jdegoes reviewed

View reviewed changes

core/shared/src/main/scala/scalaz/zio/RefM.scala Outdated Show resolved Hide resolved


          Moved error type parameter from RefM to corresponding methods

1a5cc67

jdegoes approved these changes

View reviewed changes

Member

jdegoes left a comment

Looks great!

jdegoes merged commit 1d1dd37 into zio:master

Dan-M added a commit to Dan-M/scalaz-zio that referenced this pull request


          Merge branch 'upstream/master' into feature/docusaurus

* upstream/master:
  Fixes zio#771 RefM should permit errors (zio#774)
  Add ZIO.foreach_ and variants (zio#781)

ghostdogpr pushed a commit to ghostdogpr/scalaz-zio that referenced this pull request


          Fixes zio#771 RefM should permit errors (zio#774)

339c6f4

* Fixes zio#771 RefM should permit errors

* Moved error type parameter from `RefM` to corresponding methods

GodPlaysChess deleted the refM-should-permit-errors-#771 branch

May 26, 2019 20:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment