Deprecate Await Race Variants #7761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
raceAwaitandraceFirstAwaitand changes the semantics ofraceandraceFirstto await the interruption of the loser. If you don't want to await the interruption of the loser you candisconnectit.These operators have created inconsistency with other operators derived from
raceand risk a proliferation of variants, creating uncertainty about which version to use. In addition, not waiting for termination can be the source of subtle bugs if resources are not released on a timely basis, whereas waiting for termination when it is not desired typically results in a 'loud" failure that is easily solved by usingdisconnect.