Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ZIO.succeedNow #7816

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Delete ZIO.succeedNow #7816

merged 2 commits into from
Feb 12, 2023

Conversation

adamgfraser
Copy link
Contributor

Resolves #7815.

@vigoo
Copy link
Contributor

vigoo commented Feb 12, 2023

This will break:

  • zio-keeper
  • zio-query
  • interop-cats
  • interop-guava
  • interop-rs
  • interop-twitter
  • zio-json
  • zio-http
  • zio-optics
  • zio-webhooks
  • zio-memberlist
  • zio-s3
  • zio-dynamodb
  • zio-redis
  • zio-flow
  • zio-prelude
  • zio-profiling

@jdegoes jdegoes merged commit 323f140 into zio:series/2.x Feb 12, 2023
jdegoes added a commit that referenced this pull request Feb 12, 2023
@jdegoes
Copy link
Member

jdegoes commented Feb 12, 2023

I think we need to keep ZIO.succeedNow to avoid breaking libraries but remove references to it. Libraries can be updated individually and at some point we can delete it.

@adamgfraser adamgfraser deleted the succeednow branch February 12, 2023 14:42
@adamgfraser
Copy link
Contributor Author

adamgfraser commented Feb 12, 2023

Submitted pull requests to remove references to it from all libraries:

  • ZIO HTTP
  • ZIO Prelude
  • ZIO JSON
  • Interop Cats
  • ZIO Query
  • ZIO Flow
  • ZIO Redis
  • Interop Reactive Streams
  • ZIO S3
  • ZIO DynamoDB
  • ZIO Webhooks
  • ZIO Profiling
  • Interop Monix
  • Interop Guava

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule intersection with secondOfMinute broken (StackOverflow) since ZIO 2.0.7
3 participants