New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Chunk#toArray #7851

Merged

jdegoes merged 1 commit into zio:series/2.x from adamgfraser:toarray

Feb 25, 2023

Contributor

adamgfraser commented Feb 21, 2023

We should be able to efficiently copy array backed chunks even after slicing.


          initial work

f9b9fd6

vigoo reviewed

View reviewed changes

core/shared/src/main/scala/zio/Chunk.scala

-                    right.toArray(n + left.length, dest)
+                  override protected[zio] def toArray[A1 >: A](srcPos: Int, dest: Array[A1], destPos: Int, length: Int): Unit = {
+                    val n = math.max(math.min(math.min(length, left.length - srcPos), dest.length - destPos), 0)
+                    left.toArray(srcPos, dest, destPos, n)

Contributor

vigoo Feb 22, 2023

We could skip this call completely if srcPos > left.length (the length is needed for the next line anyway)

jdegoes approved these changes

View reviewed changes

jdegoes merged commit 31c7a85 into zio:series/2.x

adamgfraser deleted the toarray branch

March 8, 2023 00:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment