Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type for zio.test.Assertion#diesWithA #7860

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

vasyl-zhurba
Copy link
Contributor

make zio.test.Assertion#diesWithA method agnostic to failure type. Before the change, it wasn't possible to compile when an effect failure type was other than Throwable

make method failure type agnostic
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2023

CLA assistant check
All committers have signed the CLA.

adamgfraser
adamgfraser previously approved these changes Feb 23, 2023
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@adamgfraser
Copy link
Contributor

@vasyl-zhurba Can you format?

@vasyl-zhurba
Copy link
Contributor Author

@vasyl-zhurba Can you format?

fixed.

@adamgfraser adamgfraser merged commit 6737c78 into zio:series/2.x Feb 24, 2023
@vasyl-zhurba vasyl-zhurba deleted the dieswitha-type-fix branch February 24, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants