Optimise _IdentityFn
#7862
Merged
Optimise _IdentityFn
#7862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's how I see this (and I can be wrong): The probability that someone using ZIO doesn't use this `_IdentityFn` lazy val is IMO close to 0. Each time you flatten a ZIO, you probably use it. AFAIR, using a `lazy val` over a `val` adds several instructions in the bytecode to make the `lazy` mechanism work. Because, this probably is low, the memory impact of this `val` not being lazy is extremelly low and the additional bytecode instructions needed for the `lazy` mechanism, I think we can just remove the `lazy` part WDYT?
|
I'm curious to hear why this was lazy in the first place. I certainly don't usually do lazy when following this pattern of saving allocations. |
|
It was probably |
jdegoes
approved these changes
Feb 25, 2023
guizmaii
added a commit
to conduktor/zio-kafka
that referenced
this pull request
Feb 28, 2023
Inspired by: - zio/zio#7862 - zio/zio#7870
guizmaii
added a commit
to conduktor/zio-kafka
that referenced
this pull request
Feb 28, 2023
Inspired by: - zio/zio#7862 - zio/zio#7870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's how I see this (and I can be wrong):
The probability that someone using ZIO doesn't use this
_IdentityFnlazy val is IMO close to 0. Each time you flatten a ZIO, you probably use it.AFAIR, using a
lazy valover avaladds several instructions in the bytecode to make thelazymechanism work.Because this probably is low, the memory impact of this
valnot being lazy is extremelly low, and the additional bytecode instructions needed for thelazymechanism, I think we can just remove thelazypartWDYT?