Un-inline Mirror in derive for layer #7889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jdegoes
approved these changes
Mar 1, 2023
|
@Kordyjan Thanks for catching this. 🙏 Will merge as soon as the tests pass! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline parameters are not stable paths, so they cannot be used in path-dependent types. Up to Scala 3.3.0-RC2, there was a bug in the compiler, and the problem was not reported.
There is one inline parameter used in path-dependent type in the ZIO codebase. It needs to be un-inlined before it is compiled with 3.3.0.
I'm not aware of any potential problems with compatibility, but I still advise merging it into a first version compiled with 3.3.0.