Optimize ZStream#sliding #7941
Merged
Optimize ZStream#sliding #7941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
approved these changes
Mar 24, 2023
jdegoes
reviewed
Mar 24, 2023
| override def slice(from: Int, until: Int): Chunk[A] = { | ||
| val start = if (from < 0) 0 else if (from > length) length else from | ||
| val end = if (until < start) start else if (until > length) length else until | ||
| Chunk.Slice(self, start, end - start) |
There was a problem hiding this comment.
Not strictly required but it can be a good idea to avoid creating the slice if from = 0, until = end.
There was a problem hiding this comment.
Interestingly this results in about a 20% reduction in the throughput of the stream benchmark, I think due to additional branching that doesn't get optimized. Of course I'm sure there are other cases where you don't actually need to create the slice that would benefit from this.
There was a problem hiding this comment.
All right, let's skip it. I was mostly thinking of stack safety in cases where slicing is done recursively based on dynamically computed bounds.
jdegoes
previously approved these changes
Mar 24, 2023
jdegoes
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.