Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Chunk.iterate #7967

Merged
merged 4 commits into from
Apr 8, 2023
Merged

Optimize Chunk.iterate #7967

merged 4 commits into from
Apr 8, 2023

Conversation

adamgfraser
Copy link
Contributor

No description provided.

@adamgfraser
Copy link
Contributor Author

MIMA was reporting binary compatibility issues on Scala 2.12 and 2.13:

[error]  * static method iterate(java.lang.Object,Int,scala.Function1)scala.collection.GenTraversable in class zio.Chunk has a different result type in current version, where it is zio.Chunk rather than scala.collection.GenTraversable
[error]  * static method iterate(java.lang.Object,Int,scala.Function1)java.lang.Object in class zio.Chunk has a different result type in current version, where it is zio.Chunk rather than java.lang.Object

However, I think these are false positives because the Chunk companion object extends IndexedSeqFactory[Chunk] and StrictOptimizedSeqFactory[Chunk] on Scala 2.12 and 2.13 which already guarantees that the output type is a Chunk and Chunk is a subtype of both GenTraversable and Object. I believe related to lightbend-labs/mima#388.

jdegoes
jdegoes previously approved these changes Apr 7, 2023
@adamgfraser adamgfraser merged commit ee52bae into zio:series/2.x Apr 8, 2023
@adamgfraser adamgfraser deleted the iterate branch June 27, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants