Preserve Scope In Stream#tapErrorCause #8248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgfraser
requested review from
jdegoes and
vigoo
and removed request for
jdegoes
jdegoes
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8244.
ZChannel.flatMapandZChannel.foldrun finalizers associated with the left hand side channel before executing the right hand side channel, as the left hand side channel is conceptually "done" at that point. In contrastZChannel.concatMapdefers running finalizers associated with the outer channel until the inner channels complete execution.Currently
ZStream.tapErrorandStream.tapErrorCausecan prematurely close the scope, because they are implemented in terms ofZChannel.fold. This PR changes this by implementing these operators in terms ofZChannel.pipeTo.