Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZManaged cats instances for Monad, MonadError, Monoid, Semigroup,… #827

Merged
merged 2 commits into from May 18, 2019
Merged

Add ZManaged cats instances for Monad, MonadError, Monoid, Semigroup,… #827

merged 2 commits into from May 18, 2019

Conversation

mschuwalow
Copy link
Member

No description provided.

iravid
iravid requested changes May 4, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general note, how about we move the ZManaged instance hierarchy to a separate trait hierarchy (and separate files)?

@mschuwalow mschuwalow mentioned this pull request May 4, 2019
Closed
@mschuwalow
Copy link
Member Author

What else needs to be done before this can be merged?

@iravid
Copy link
Member

iravid commented May 9, 2019

I'd love to get another look. Going through both of your PRs today.

iravid
iravid approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Amazing work @mschuwalow. This is good to go for me.

jdegoes
jdegoes approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excellent work and badly needed. Thank you for this contribution!

@jdegoes jdegoes merged commit da773d1 into zio:master May 18, 2019
@jdegoes
Copy link
Member

jdegoes commented May 18, 2019

giphy

@andreamarcolin andreamarcolin mentioned this pull request Jun 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

@iravid iravid iravid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mschuwalow @iravid @jdegoes