Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIO Test: Warn If Scope Cannot Be Closed #8288

Merged
merged 3 commits into from Jul 28, 2023
Merged

ZIO Test: Warn If Scope Cannot Be Closed #8288

merged 3 commits into from Jul 28, 2023

Conversation

adamgfraser
Copy link
Contributor

@adamgfraser adamgfraser commented Jul 28, 2023 •
edited

Resolves #8284. /claim #8284.

@algora-pbc algora-pbc bot mentioned this pull request Jul 28, 2023
Closed
@jdegoes
Copy link
Member

jdegoes commented Jul 28, 2023

Looks great! Would be useful to add a single test to ensure that a "never" layer that does not ever finalize can be handled using this.

jdegoes
jdegoes previously approved these changes Jul 28, 2023
View reviewed changes
@adamgfraser adamgfraser requested a review from jdegoes July 28, 2023 18:40
@jdegoes jdegoes merged commit 32928b5 into zio:series/2.x Jul 28, 2023
22 checks passed
@adamgfraser adamgfraser deleted the finalizer branch August 20, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZIO Test: Automatically disconnect layers with diagnostic information
2 participants
@adamgfraser @jdegoes