fix ambiguity checks in ZLayer#provide macro #8580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zlayer#provide*
macro family sometimes allows having duplicate layers for the same dependency. Here's an exampleIn the above example we've got three different repository implementations, one of which is a combination of two of them.
If we use them like this
The code will compile fine without any warnings. Though it will do an expected thing (it will actually construct and use
RepositoryLive
), this is quite unexpected since any of three layers could've been used. If we just change their order like thisthen it will produce a warning that
RepositoryLive.live
andGreenplumRepository.live
are unused. But overall I'd say that in this case the behaviour is undefined and should be allowed. That's why this MR exists ¯_(ツ)_/¯