Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafeRunToTwitterFuture for twitter Future #882

Merged
merged 3 commits into from
May 29, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@

package scalaz.zio.interop

import com.twitter.util.{ Future, FutureCancelledException, Return, Throw }
import scalaz.zio.{ Task, UIO }
import com.twitter.util.{ Future, FutureCancelledException, Promise, Return, Throw }
import scalaz.zio.Exit.Cause
import scalaz.zio.{ Runtime, Task, UIO, ZIO }

package object twitter {
implicit class TaskObjOps(private val obj: Task.type) extends AnyVal {
Expand All @@ -33,4 +34,23 @@ package object twitter {
}
}
}

implicit class RuntimeOps[R](private val runtime: Runtime[R]) extends AnyVal {
def unsafeRunToTwitterFuture[A](io: ZIO[R, Throwable, A]): Future[A] = {
val promise = Promise[A]()
def failure(cause: Cause[Throwable]): Unit = promise.setException(cause.squash)
def success(value: A): Unit = promise.setValue(value)

runtime.unsafeRunAsync {
io.fork.flatMap { f =>
promise.setInterruptHandler {
case _ => runtime.unsafeRunAsync_(f.interrupt)
}
f.join
}
}(_.fold(failure, success))

promise
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,32 @@ package scalaz.zio.interop

import java.util.concurrent.atomic.AtomicInteger

import com.twitter.util.{ Future, JavaTimer, Duration => TwitterDuration }
import com.twitter.util.{ Await, Future, JavaTimer, TimeoutException, Timer, Duration => TwitterDuration }
import org.specs2.concurrent.ExecutionEnv
import org.specs2.specification.AfterAll
import scalaz.zio.Exit.Cause.Fail
import scalaz.zio.duration._
import scalaz.zio.interop.twitter._
import scalaz.zio.{ FiberFailure, Task, TestRuntime, ZIO }

class TwitterSpec(implicit ee: ExecutionEnv) extends TestRuntime {
class TwitterSpec(implicit ee: ExecutionEnv) extends TestRuntime with AfterAll {
def is =
"Twitter spec".title ^ s2"""
`Task.fromTwitterFuture` must
return failing `Task` if future failed. $propagateFailures
return successful `Task` if future succeeded. $propagateResults
ensure future is interrupted together with task. $propagateInterrupts

`Runtime.unsafeRunToTwitterFuture` must
return successful `Future` if Task evaluation succeeded. $evaluateToSuccessfulFuture
return failed `Future` if Task evaluation failed. $evaluateToFailedFuture
ensure Task evaluation is interrupted together with Future. $evaluateToInterruptedFuture
"""

private implicit val twitterTimer: Timer = new JavaTimer(true)

override def afterAll: Unit = twitterTimer.stop()

private def propagateFailures = {
val error = new Exception
val future = Task(Future.exception[Int](error))
Expand All @@ -35,8 +45,6 @@ class TwitterSpec(implicit ee: ExecutionEnv) extends TestRuntime {
}

private def propagateInterrupts = {
implicit val timer = new JavaTimer(true)

val value = new AtomicInteger(0)
val futureDelay = TwitterDuration.fromSeconds(1)
val future = Task.succeed(Future.sleep(futureDelay).map(_ => value.incrementAndGet()))
Expand All @@ -47,4 +55,26 @@ class TwitterSpec(implicit ee: ExecutionEnv) extends TestRuntime {
unsafeRun(task <* ZIO.unit.delay(3.seconds)) must beNone
value.get() ==== 0
}

private def evaluateToSuccessfulFuture = {
Await.result(this.unsafeRunToTwitterFuture(Task.succeed(1))) ==== 1
Await.result(this.unsafeRunToTwitterFuture(Task.succeed(2).delay(100.millis))) ==== 2
}

yaroot marked this conversation as resolved.
Show resolved Hide resolved
private def evaluateToFailedFuture = {
val e = new Exception
val task = ZIO.unit.delay(100.millis) *> Task.fail(e).unit

Await.result(this.unsafeRunToTwitterFuture(task)) must throwAn(e)
}

private def evaluateToInterruptedFuture = {
val value = new AtomicInteger(0)
val futureTimeout = TwitterDuration.fromMilliseconds(100)

val task = ZIO.unit.delay(500.millis) *> Task.effect(value.incrementAndGet())
yaroot marked this conversation as resolved.
Show resolved Hide resolved

Await.result(this.unsafeRunToTwitterFuture(task).raiseWithin(futureTimeout)) must throwAn[TimeoutException]
unsafeRun(ZIO.unit.delay(600.millis) *> Task.effect(value.get)) ==== 0
}
}