[WIP] ZStream.groupedWithin works in unexpected way for infinite stream #8686 #8873
+42
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #8686
If I understand correctly, the issue could happen when producer is fast, in such cases schedule could be ignored in function
aggregateAsyncWithinEither. I think it happens because in this codewaitForSchedule.raceWith(waitForProducer)there is no guarantee thatwaitForSchedulefiber would win race withwaitForProducereven if scheduler had already signaled. These issues could also be related:In this PR before entering the race I just check whether scheduler was fired on the previous iteration
I believe there is a better way to fix