Add support for comparing related types in assertTrue in Scala 2 #8875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
approved these changes
May 20, 2024
| for { | ||
| result <- resultZIO | ||
| } yield assertTrue(result.is(_.left).contains("type mismatch")) | ||
| } @@ scala2Only, | ||
| test("comparison compiles when comparing different types") { |
There was a problem hiding this comment.
Can you mark this one as 'primitive' as well?
There was a problem hiding this comment.
Fixed - after this is merged I can add more tests related to comparing - comparing unrelated classes, comparing related classes etc. - I believe currently behaviour is a bit undefined there.
hearnadam
reviewed
May 24, 2024
| for { | ||
| result <- resultZIO | ||
| } yield assertTrue(result.is(_.left).contains("type mismatch")) | ||
| } @@ scala2Only, |
There was a problem hiding this comment.
Will this not fail with 'type mismatch' on Scala 3?
There was a problem hiding this comment.
Nope:
- SmartAssertionSpec / equalTo does not compile when comparing unrelated types in Scala 2 - 26 ms
? Either was Right
result.is(_.left).contains("type mismatch")
result = Right(value = ())
at D:\MojeProgramy\zio\test-tests\shared\src\test\scala\zio\test\SmartAssertionSpec.scala:227
but it does not work correctly (at least the diffing part): #8754
|
@andrzejressel Would like to get this in. Please re-open when CI is passing! 🙏 |
|
But it passed everything ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8874