Rename all packages from scalaz.zio to zio._ #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ReiReiRei This looks great! Can you fix the merge conflicts? |
|
@jdegoes Yes, of course |
ReiReiRei
changed the title
# Conflicts: # streams/jvm/src/test/scala/zio/stream/SinkSpec.scala # streams/shared/src/main/scala/scalaz/stream/ZSink.scala # streams/shared/src/main/scala/scalaz/stream/ZStreamChunk.scala
ReiReiRei
changed the title
|
@jdegoes I've finished the fixes, I think this PR should be merged as soon as possible because of a lot of file's path have been renamed, and any new file can produce a merge conflict |
jdegoes
approved these changes
Jun 2, 2019
|
@ReiReiRei Done. Thank you for your work on this (I really hope you had tool support! 😄), and congratulations on your first PR to ZIO!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all packages from scalaz.zio to zio._