Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on tilde versioning for rspec #260

Closed
wants to merge 1 commit into from
Closed

Conversation

ianks
Copy link
Contributor

@ianks ianks commented Feb 16, 2016

This versioning scheme communicates that all rspec versions greater than or equal to 3.0 are supported, by rspec 4 is not. This make sense, sense there is no rspec 4. This change effectively does nothing, but future-proofs us when rspec 4 is released.

@oestrich
Copy link
Contributor

We're already protected by the rspec 4 upgrade with what we have. The extra >= 3.0.0 is just to specific the minimum version inside of the tilde we support. Creating the gem via gem build brings up warnings unless that is there.

@ianks
Copy link
Contributor Author

ianks commented Feb 16, 2016

Yes you are right about being protected against rspec 4. But doesn't this tilde versioning support 3.0.0? Thus making the >= redundant?

@oestrich
Copy link
Contributor

I was just going off what gem build said. Here is how it's complaining about activesupport

WARNING:  open-ended dependency on activesupport (>= 3.0.0) is not recommended
  if activesupport is semantically versioned, use:
    add_runtime_dependency 'activesupport', '~> 3.0', '>= 3.0.0'

I removed the >= 3.0.0 from the rspec line and it's not complaining any more. We can merge once the build passes.

@oestrich
Copy link
Contributor

oestrich commented Dec 8, 2016

Handled this locally. Thanks!

@oestrich oestrich closed this Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants