Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update $_required typehint #1568

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

DjordyKoert
Copy link
Contributor

NelmioApiDocBundle is currently attempting to upgrade PHPStan to level 6.

Our annotations which extend AbstractAnnotation are generating errors. A simple typehint fixes this which is the reason for this PR :)

https://github.com/nelmio/NelmioApiDocBundle/blob/a585e502725d7e3cfcec25f7a3d59443842006da/src/Annotation/Model.php#L30

 ------ -------------------------------------------------------------------------------------------------------------------- 
  Line   Annotation/Model.php                                                                                                
 ------ -------------------------------------------------------------------------------------------------------------------- 
  30     Property Nelmio\ApiDocBundle\Annotation\Model::$_required type has no value type specified in iterable type array.  
         💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                           
 ------ -------------------------------------------------------------------------------------------------------------------- 

@DerManoMann DerManoMann merged commit 7819531 into zircote:master Apr 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants