Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #460

Closed
wants to merge 1 commit into from
Closed

Conversation

carusogabriel
Copy link
Contributor

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

I just need to bump PHPUnit version to >=4.8.35, that support this namespace.

@bfanger
Copy link
Collaborator

bfanger commented Nov 18, 2017

Thanks, but the 3.x branch already uses phpunit 6+

@bfanger
Copy link
Collaborator

bfanger commented Nov 24, 2017

Merged as 8bb17cf
Makes it possible to switch between master and the 3.x branch without having to install another phpunit version.

Thanks!

@bfanger bfanger closed this Nov 24, 2017
@carusogabriel carusogabriel deleted the phpunit branch November 24, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants