Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting URL parameters when calling device authorization endpoint #354

Closed
monstermunchkin opened this issue Mar 29, 2023 · 5 comments · Fixed by #356
Closed

Allow setting URL parameters when calling device authorization endpoint #354

monstermunchkin opened this issue Mar 29, 2023 · 5 comments · Fixed by #356
Labels
enhancement New feature or request released on @next released
Milestone
v3

Comments

@monstermunchkin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When using the device authorization flow, it's currently not possible to set URL parameters when calling the device authorization endpoint. In some cases, the OP would like to receive the audience parameter in order to issue a proper access token.

Describe the solution you'd like
It would be nice if URL parameters could somehow be passed when calling rp.DeviceAuthorization(). A solution could be to add an authFn argument to both rp.DeviceAuthorization() and client.CallDeviceAuthorizationEndpoint() which could then be passed to httphelper.FormRequest(). But this would break backward compatibility.
@monstermunchkin monstermunchkin added the enhancement New feature or request label Mar 29, 2023
@muhlemmer
Copy link
Collaborator

This change would be fine on the next branch for backward-incompatible changes and a future v3 release.

@monstermunchkin
Copy link
Contributor Author

@muhlemmer

Should I send a PR for this change, or would you like to fix this some other way? Also, do you know when v3 will be released?

@muhlemmer
Copy link
Collaborator

Yes, a PR is welcome. We don't have a strict deadline, but I recon within a month-ish. We do have auto-releases on v3 already that you could use a target. Just expect that there are breaking changes with each increment.

monstermunchkin added a commit to monstermunchkin/oidc that referenced this issue Mar 30, 2023
@monstermunchkin
feat: Allow modifying request to device authorization endpoint
2c660d8 
This change enables the caller to set URL parameters when calling the
device authorization endpoint.

Resolves zitadel#354
@monstermunchkin monstermunchkin mentioned this issue Mar 30, 2023
Merged
@muhlemmer muhlemmer linked a pull request Apr 3, 2023 that will close this issue
feat: Allow modifying request to device authorization endpoint #356
Merged
muhlemmer pushed a commit that referenced this issue Apr 3, 2023
@monstermunchkin
feat: Allow modifying request to device authorization endpoint (#356)
c778e83 
* feat: Allow modifying request to device authorization endpoint

This change enables the caller to set URL parameters when calling the
device authorization endpoint.

Fixes #354

* Update device authorization example
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

🎉 This issue has been resolved in version 3.0.0-next.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@muhlemmer muhlemmer added this to the v3 milestone Apr 22, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released on @next released
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

feat: Allow modifying request to device authorization endpoint monstermunchkin/oidc
2 participants
@monstermunchkin @muhlemmer