Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow modifying request to device authorization endpoint #356

Merged

Conversation

monstermunchkin
Copy link
Contributor

This change enables the caller to set URL parameters when calling the
device authorization endpoint.

Resolves #354

This change enables the caller to set URL parameters when calling the
device authorization endpoint.

Resolves zitadel#354
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #356 (bbf831f) into next (adebbe4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             next     #356   +/-   ##
=======================================
  Coverage   52.40%   52.40%           
=======================================
  Files          74       74           
  Lines        5574     5574           
=======================================
  Hits         2921     2921           
  Misses       2401     2401           
  Partials      252      252           
Impacted Files Coverage Δ
pkg/client/client.go 20.10% <0.00%> (ø)
pkg/client/rp/device.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fforootd fforootd requested a review from muhlemmer March 31, 2023 08:54
@fforootd
Copy link
Member

Thanks for the PR, lets us review this soon.

@muhlemmer muhlemmer merged commit c778e83 into zitadel:next Apr 3, 2023
@muhlemmer
Copy link
Collaborator

Thanks!

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

🎉 This PR is included in version 3.0.0-next.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@muhlemmer muhlemmer added this to the v3 milestone Apr 22, 2023
@github-actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting URL parameters when calling device authorization endpoint
3 participants