Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade pnpm, pkgs and ran lint fix #64

Closed
wants to merge 1 commit into from

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Apr 13, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Jest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented Apr 13, 2024

@yordis is attempting to deploy a commit to the zitadel Team on Vercel.

A member of the Team first needs to authorize it.

@yordis
Copy link
Contributor Author

yordis commented Apr 13, 2024

@peintnermax, do you think it is possible to take this so that my other #63 becomes a bit cleaner?

@yordis yordis force-pushed the chore-clean-up-dev-env branch 2 times, most recently from 73ea944 to 95fec9d Compare April 13, 2024 03:14
@yordis yordis changed the title chore: upgrade pnpm and ran lint fix chore: upgrade pnpm, pkgs and ran lint fix Apr 13, 2024
@yordis yordis marked this pull request as draft April 13, 2024 03:19
@yordis yordis force-pushed the chore-clean-up-dev-env branch 4 times, most recently from 578b1cb to 456db13 Compare April 13, 2024 03:47
@yordis
Copy link
Contributor Author

yordis commented Apr 13, 2024

@peintnermax I know I am doing a bit more, but honestly, I think that keeping up to date with the dips will pay off; the CI is failing due to some compilation issue that is a bit weird; maybe you can give it a try, and see what the problem is.

I will pick it up for another few hours tomorrow.

@yordis
Copy link
Contributor Author

yordis commented Apr 13, 2024

Screenshot 2024-04-13 at 12 01 53 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants