feat: introduce parameterization to probe schemes #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pisarz
force-pushed
the
introduce-parameterization-to-probe-schemes
branch
2 times, most recently
from
eae1bfe
to
c1dfd5d
Compare
pisarz
force-pushed
the
introduce-parameterization-to-probe-schemes
branch
from
c1dfd5d
to
55eade9
Compare
eliobischof
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
hey @pisarz thanks for this feature and sorry for the very late review 🥲 I only moved the default scheme to the values.yaml and bumped the charts version.
If you'd like to have a small gift in return, please send us a mail to hi@zitadel.com. We will send you a form with questions about your address and shirt size.
kleberbaum
pushed a commit
to fhkit/zitadel-charts
that referenced
this pull request
May 24, 2024
* feat: Introduce parameterization to probe schemes * move default scheme to values.yaml --------- Co-authored-by: Elio Bischof <elio@zitadel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
schemefield, which specifies the scheme (HTTP or HTTPS) used in the health, liveness and readiness probes of the ZITADEL service.This can be useful for configuring how the probes interact with the service depending on the protocol that is being used. The default "HTTP" part ensures that if the scheme value is not provided in the .Values.service.scheme field, it defaults to "HTTP"
Definition of Ready