Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove test pod #182

Merged
merged 3 commits into from
Mar 4, 2024
Merged

fix: remove test pod #182

merged 3 commits into from
Mar 4, 2024

Conversation

eliobischof
Copy link
Member

Closes #124

We test using a go test suite, so we don't need the test pod. This makes templating easier.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof requested a review from stebenz March 1, 2024 09:13
@eliobischof eliobischof self-assigned this Mar 1, 2024
@eliobischof eliobischof changed the title chore: remove test pod fix: remove test pod Mar 1, 2024
@eliobischof eliobischof enabled auto-merge (squash) March 1, 2024 16:53
@eliobischof eliobischof merged commit 072416e into main Mar 4, 2024
9 checks passed
@eliobischof eliobischof deleted the remove-test-pod branch March 4, 2024 10:32
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
@eliobischof
fix: remove test pod (zitadel#182)
f3bd230 
* chore: remove test pod

* patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stebenz stebenz stebenz approved these changes

Assignees

@eliobischof eliobischof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make test-connection pod optional
2 participants
@eliobischof @stebenz