Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to mount server ssl cert from secret #199

Merged
merged 4 commits into from
May 6, 2024

Conversation

Exeteres
Copy link
Contributor

It seems that there is no way to specify a secret with certificate for listening on HTTPS.
Now there is :)

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Apr 30, 2024
@fforootd
Copy link
Member

Thank you ❤️ for this PR

Let us review this!

Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this feature @Exeteres 🥳

If you'd like us to send you a small gift in return, please send us a mail to hi@zitadel.com. We will send you a form with questions about your shirt size and address.

@eliobischof eliobischof merged commit 8831017 into zitadel:main May 6, 2024
10 checks passed
@kleberbaum kleberbaum mentioned this pull request May 7, 2024
11 tasks
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
* feat: Add ability to mount server ssl cert from secret

* fix lint

* bump

---------

Co-authored-by: Elio Bischof <elio@zitadel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants