Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update appVersion to v2.51.3 #198

Merged
merged 7 commits into from
May 8, 2024
Merged

Conversation

kleberbaum
Copy link
Contributor

@kleberbaum kleberbaum commented Apr 30, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

What is the current behavior?
The previously implemented workflow functionality from PR zitadel/zitadel#4544, which automatically triggered a webhook post-ZITADEL release, has been removed. Consequently, the bump workflow (introduced in #43 and discussed in Issue #105) is no longer dispatched, as it depends on this mechanism. This issue is also tracked in the Product Management Backlog under item 30889015.

What is the new behavior?
This PR updates the ZITADEL version to v2.51.0 manually.

What could be a permanent solution?
To resolve Issue #105 it may be necessary to reimplement the changes from PR zitadel/zitadel#4544 in Current ZITADEL Release Workflow.

      - uses: tibdex/github-app-token@v1
        id: generate-token
        with:
          app_id: ${{ secrets.APP_ID }}
          private_key: ${{ secrets.APP_PRIVATE_KEY }}
      - name: Bump Chart Version
        uses: peter-evans/repository-dispatch@v2
        if: steps.semantic.outputs.new_release_published == 'true' && github.ref == 'refs/heads/main'
        with:
          token: ${{ steps.generate-token.outputs.token }}
          repository: zitadel/zitadel-charts
          event-type: zitadel-released
          client-payload: '{"semanticoutputs": "${{ steps.semantic.outputs }}"}'

However, the current bump workflow does not appear to be functional, as indicated by Bump Version.

image

Your feedback and suggestions would be greatly appreciated.

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Apr 30, 2024
eliobischof
eliobischof previously approved these changes May 6, 2024
charts/zitadel/Chart.yaml Outdated Show resolved Hide resolved
Co-authored-by: Elio Bischof <elio@zitadel.com>
@kleberbaum kleberbaum changed the title feat: update appVersion to v2.51.0 feat: update appVersion to v2.51.2 May 6, 2024
@eliobischof eliobischof enabled auto-merge (squash) May 6, 2024 15:32
@kleberbaum
Copy link
Contributor Author

kleberbaum commented May 6, 2024

It appears that the check failure was not caused by a bug, but rather a minor hiccup in the GitHub workflow, especially since it was successfully with v2.51.0. I suggest rerunning the check for K8s version v1.21 to see if the problem persists.
image

eliobischof
eliobischof previously approved these changes May 6, 2024
@eliobischof
Copy link
Member

@kleberbaum the flakiness is fixed on main.
Please merge back main. It seems I don't have the permission to push to your repo myself.

@eliobischof
Copy link
Member

depends on #202

Copy link
Contributor Author

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like someone jumped the queue #199 😄

charts/zitadel/Chart.yaml Outdated Show resolved Hide resolved
auto-merge was automatically disabled May 7, 2024 06:46

Head branch was pushed to by a user without write access

@kleberbaum
Copy link
Contributor Author

Could we expedite the merge?😅 I'm relying on the updated Helm chart for a project deployment that utilizes the new email features introduced in Zitadel. @eliobischof

@rhizoet
Copy link

rhizoet commented May 8, 2024

The version v2.51.3 has been released. Maybe you can update to this version before the merge?

@eliobischof
Copy link
Member

@kleberbaum @rhizoet are you aware that you can always overwrite the charts default appVersion in your local helm release config?

@eliobischof eliobischof merged commit a914368 into zitadel:main May 8, 2024
10 checks passed
@kleberbaum
Copy link
Contributor Author

Thanks for the merge 🎉 I see the ZITADEL version tag in values.yaml can be overwritten. @eliobischof @rhizoet
image

However, I prefer upgrading deployments like this:

# Add ZITADEL repository
helm repo add zitadel https://charts.zitadel.com

# Get deployment values
helm get values zitadel -n mynamespace > zitadel-values.yaml

# Upgrade to the latest or a specific version
helm upgrade zitadel zitadel/zitadel -f zitadel-values.yaml -n mynamespace
helm upgrade zitadel zitadel/zitadel --version 7.14.0 -f zitadel-values.yaml -n mynamespace

This method ensures clear version tracking in helm history.

helm history zitadel -n mynamespace

image

@kleberbaum kleberbaum changed the title feat: update appVersion to v2.51.2 feat: update appVersion to v2.51.3 May 8, 2024
@eliobischof
Copy link
Member

Thanks for the merge 🎉 I see the ZITADEL version tag in values.yaml can be overwritten. @eliobischof @rhizoet
image

However, I prefer upgrading deployments like this:

# Add ZITADEL repository
helm repo add zitadel https://charts.zitadel.com

# Get deployment values
helm get values zitadel -n mynamespace > zitadel-values.yaml

# Upgrade to the latest or a specific version
helm upgrade zitadel zitadel/zitadel -f zitadel-values.yaml -n mynamespace
helm upgrade zitadel zitadel/zitadel --version 7.14.0 -f zitadel-values.yaml -n mynamespace

This method ensures clear version tracking in helm history.

helm history zitadel -n mynamespace

image

Ah, I didn't consider that 😃 thanks for sharing

kleberbaum added a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
* Update appVersion to v2.51.0

* Update chart version to 7.13.0

* Update appVersion to v2.51.2

Co-authored-by: Elio Bischof <elio@zitadel.com>

* Update chart version to 7.14.0

* Update appVersion to v2.51.3

---------

Co-authored-by: Elio Bischof <elio@zitadel.com>
kleberbaum added a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
* Update appVersion to v2.51.0

* Update chart version to 7.13.0

* Update appVersion to v2.51.2

Co-authored-by: Elio Bischof <elio@zitadel.com>

* Update chart version to 7.14.0

* Update appVersion to v2.51.3

---------

Co-authored-by: Elio Bischof <elio@zitadel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants