Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pending checks #202

Merged
merged 2 commits into from
May 8, 2024
Merged

chore: fix pending checks #202

merged 2 commits into from
May 8, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented May 6, 2024

Checks that have path filters are stuck in a pending state if the filter doesn't match any changed file. If these checks are required, they block merging PRs.

This PR removes the path filter in the pipeline. Instead, it uses an action to identify changed files. The actions output is used as a condition for all subsequent steps. The pipelines always run and are marked as successful if no relevant files changed.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

Copy link
Contributor

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides adding a newline below steps, everything looks good to me (LGTM)👍

.github/workflows/test.yml Outdated Show resolved Hide resolved
stebenz
stebenz previously approved these changes May 7, 2024
Co-authored-by: Florian H. Kleber <kleber@snek.at>
@eliobischof eliobischof merged commit ba05e3d into main May 8, 2024
10 checks passed
@eliobischof eliobischof deleted the fix-pending-checks branch May 8, 2024 07:37
kleberbaum added a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
* chore: fix pending checks

* Update .github/workflows/test.yml

Co-authored-by: Florian H. Kleber <kleber@snek.at>

---------

Co-authored-by: Florian H. Kleber <kleber@snek.at>
kleberbaum added a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
* chore: fix pending checks

* Update .github/workflows/test.yml

Co-authored-by: Florian H. Kleber <kleber@snek.at>

---------

Co-authored-by: Florian H. Kleber <kleber@snek.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants