chore(deps-dev): bump @angular/cli from 11.2.7 to 11.2.8 in /console (#…

…1566)

* fix: remove app name check on ChangeAPIApplication (#1561)

* fix: remove app name check on ChangeAPIApplication

* fix APIConfigInvalid message

* chore(workflow): ignore tags for docs and codecov flows (#1564)

* chore(deps-dev): bump @angular/cli from 11.2.7 to 11.2.8 in /console

Bumps [@angular/cli](https://github.com/angular/angular-cli) from 11.2.7 to 11.2.8.
- [Release notes](https://github.com/angular/angular-cli/releases)
- [Commits](angular/angular-cli@v11.2.7...v11.2.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Livio Amstutz <livio.a@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/workflows/codecov.yml

@@ -1,5 +1,10 @@
 name: Code Coverage
-on: push
+on:
+  push:
+    branches:
+      - '**'
+    tags-ignore:
+      - '**'
 
 env:
   REGISTRY: ghcr.io

.github/workflows/docs.yml

@@ -3,7 +3,8 @@ on:
   push:
     paths:
       - 'site/**'
-
+    tags-ignore:
+      - '**'
 env:
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

console/package.json

@@ -45,7 +45,7 @@
     "zone.js": "~0.11.3"
   },
   "devDependencies": {
-    "@angular/cli": "~11.2.7",
+    "@angular/cli": "~11.2.8",
     "@angular-devkit/build-angular": "~0.1102.7",
     "@angular/compiler-cli": "~11.0.0",
     "@types/jasmine": "~3.6.3",

internal/command/project_application_api.go

@@ -69,7 +69,7 @@ func (c *Commands) addAPIApplication(ctx context.Context, projectAgg *eventstore
 }
 
 func (c *Commands) ChangeAPIApplication(ctx context.Context, apiApp *domain.APIApp, resourceOwner string) (*domain.APIApp, error) {
-	if !apiApp.IsValid() || apiApp.AppID == "" || apiApp.AggregateID == "" {
+	if apiApp.AppID == "" || apiApp.AggregateID == "" {
 		return nil, caos_errs.ThrowInvalidArgument(nil, "COMMAND-1m900", "Errors.Project.App.APIConfigInvalid")
 	}
 

internal/command/project_application_api_test.go

@@ -272,27 +272,6 @@ func TestCommandSide_ChangeAPIApplication(t *testing.T) {
 		args   args
 		res    res
 	}{
-		{
-			name: "invalid app, invalid argument error",
-			fields: fields{
-				eventstore: eventstoreExpect(
-					t,
-				),
-			},
-			args: args{
-				ctx: context.Background(),
-				apiApp: &domain.APIApp{
-					ObjectRoot: models.ObjectRoot{
-						AggregateID: "project1",
-					},
-					AppID: "app1",
-				},
-				resourceOwner: "org1",
-			},
-			res: res{
-				err: caos_errs.IsErrorInvalidArgument,
-			},
-		},
 		{
 			name: "missing appid, invalid argument error",
 			fields: fields{

internal/static/i18n/en.yaml

@@ -194,7 +194,7 @@ Errors:
       NotActive:: Application is not active
       NotInactive: Application is not inactive
       OIDCConfigInvalid: OIDC configuration is invalid
-      APIConfigInvalid: OIDC configuration is invalid
+      APIConfigInvalid: API configuration is invalid
       IsNotOIDC: Application is not type oidc
       IsNotAPI: Application is not type API
       OIDCAuthMethodNoSecret: Chosen OIDC Auth Method does not require a secret