Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

Test ckeditor semantic #27

Merged
merged 6 commits into from
Nov 13, 2015
Merged

Test ckeditor semantic #27

merged 6 commits into from
Nov 13, 2015

Conversation

grndlvl
Copy link
Member

@grndlvl grndlvl commented Nov 10, 2015

Testing new ckeditor media plugin changes.

@jodyHamilton
Copy link
Contributor

@jonathan https://55905c33-c677-4e1e-ad2c-470e869ac994.probo.build/admin/config/ckeditor_media_embed/settings should be under admin/config/media . And it needs a page title.

Since there is no way to reset to the default setting, it would be nice to include what the default is explicitly in the help text. Also some links to potential providers would be useful in that help text.

I tried the input filter, but it seemed like the wysiwyg mangled the oembed tags. https://55905c33-c677-4e1e-ad2c-470e869ac994.probo.build/node/2/edit

@grndlvl
Copy link
Member Author

grndlvl commented Nov 10, 2015

Will make the changes to the path and title + default and some other providers.

The filter works as expected. If you're inserting tags directly you need to first click "source" otherwise everything is escaped.

Though you can use this filter directly, if the Semantic Button is the one enabled (The one I selected on this build) then if you take a look at the devel output you'll see the tags instead of the embed html.

@grndlvl
Copy link
Member Author

grndlvl commented Nov 11, 2015

I went ahead and re-merged with 8.x it looks like now it's not using the right profile. It installed the wrong version of the CKEditor media embed module...

But basically I added a Help page and linked to it from the configuration page. It looks very similar to the project page. https://www.drupal.org/sandbox/grndlvl/2597734

jodyHamilton added a commit that referenced this pull request Nov 13, 2015
@jodyHamilton jodyHamilton merged commit 5ef3d87 into 8.x Nov 13, 2015
@jodyHamilton jodyHamilton deleted the TestCKEditorSemantic branch November 13, 2015 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants