Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native Python and update results #19

Merged
merged 1 commit into from
Oct 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@

evm-bench makes it easy to compare EVM performance in a scalable, standardized, and portable way.

| | py-evm.cpython | py-evm.pypy | pyrevm | revm |
| ----------------------- | -------------- | ----------- | ------- | ------ |
| erc20.approval-transfer | 1.9362s | 424.2ms | 16.8ms | 9.8ms |
| erc20.mint | 1.8968s | 374ms | 15ms | 5.6ms |
| erc20.transfer | 2.7296s | 482.6ms | 23.4ms | 11.4ms |
| snailtracer | 37.861s | 7.409s | 131.7ms | 60.7ms |
| ten-thousand-hashes | 4.1496s | 632ms | 17ms | 6.8ms |
| | | | | |
| **sum** | 48.6s | 9.32s | 203ms | 94.3ms |
| **relative** | 515x | 98.8x | 2.15x | 1.00x |
| | py-evm.cpython | py-evm.pypy | pyrevm | revm |
| ----------------------- | -------------- | ----------- | ------ | ------ |
| erc20.approval-transfer | 1.4258s | 377.2ms | 16.8ms | 10ms |
| erc20.mint | 1.4092s | 347.8ms | 14.4ms | 5.6ms |
| erc20.transfer | 1.9988s | 420.8ms | 22.6ms | 11.4ms |
| snailtracer | 17.857s | 5.17s | 138ms | 58ms |
| ten-thousand-hashes | 3.4344s | 665.6ms | 18.2ms | 7ms |
| | | | | |
| **sum** | 26.1252s | 6.9814s | 210ms | 92ms |
| **relative** | 284x | 75.9x | 2.28x | 1.00x |

To reproduce these results, check out [usage with the evm-bench suite below](#with-the-evm-bench-suite).

Expand Down
2 changes: 1 addition & 1 deletion benchmarks/snailtracer/benchmark.evm-bench.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "../schema.json",
"name": "snailtracer",
"num-runs": 3,
"num-runs": 1,
"solc-version": "0.4.26",
"contract": "SnailTracer.sol",
"calldata": "30627b7c"
Expand Down
2 changes: 1 addition & 1 deletion runners/py-evm/cpython/entry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -e
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

cd $SCRIPT_DIR
poetry env use python3.9 >&2
poetry env use python3 >&2
poetry install >&2
poetry update >&2
poetry run python ../runner.py $@
4 changes: 2 additions & 2 deletions runners/py-evm/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion runners/py-evm/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description = ""
authors = ["Ziyad Edher <ziyad.edher@gmail.com>"]

[tool.poetry.dependencies]
python = "^3.9,<3.10"
python = "^3.9"
py-evm = "^0.6.0-alpha.1"

[tool.poetry.dev-dependencies]
Expand Down
6 changes: 3 additions & 3 deletions runners/py-evm/runner.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import argparse
from typing import Final, cast
from typing import cast, Final

import argparse
import pathlib
import time

Expand Down Expand Up @@ -44,7 +44,7 @@ def _construct_chain() -> eth.chains.base.MiningChain:
chain = chain_class.from_genesis(
eth.db.atomic.AtomicDB(),
genesis_params={
"difficulty": 100,
"difficulty": 1,
"gas_limit": 2 * GAS_LIMIT,
},
)
Expand Down
37 changes: 29 additions & 8 deletions src/results.rs
Original file line number Diff line number Diff line change
Expand Up @@ -101,31 +101,52 @@ pub fn print_results(results_file_path: &Path) -> Result<(), Box<dyn error::Erro
let mut runs = results.runs.into_iter().collect::<Vec<_>>();
runs.sort_by_key(|(b, _)| b.clone());

let mut runner_times = HashMap::<String, Vec<Duration>>::new();

let mut builder = Builder::default();
for (benchmark_name, benchmark_runs) in runs.iter() {
let vals = runner_names.iter().map(|runner_name| {
let run = benchmark_runs.get(runner_name)?;
Some(
run.run_times
.iter()
.fold(Duration::ZERO, |a, v| a + v.clone())
.div_f64(run.run_times.len() as f64),
)
let avg_run_time = run
.run_times
.iter()
.fold(Duration::ZERO, |a, v| a + v.clone())
.div_f64(run.run_times.len() as f64);
runner_times
.entry(runner_name.clone())
.or_default()
.push(avg_run_time);
Some(avg_run_time)
});

let mut record = vec![benchmark_name.clone()];
record.extend(
vals.map(|val| Some(format!("{:?}", val?)))
.map(|s| s.unwrap_or("".into())),
.map(|s| s.unwrap_or_default()),
);
builder.add_record(record);
}

let average_runner_times = runner_times
.into_iter()
.map(|(name, times)| (name, times.iter().sum::<Duration>()))
.collect::<HashMap<String, Duration>>();
let mut record = vec!["sum".to_string()];
record.extend(
runner_names
.iter()
.map(|runner_name| average_runner_times.get(runner_name))
.map(|val| Some(format!("{:?}", val?)))
.map(|s| s.unwrap_or_default()),
);
builder.add_record(record);

let mut columns = vec!["".to_owned()];
columns.extend(runner_names);
builder.set_columns(columns);

let mut table = builder.build();
table.with(Style::rounded());
table.with(Style::markdown());
println!("{}", table);

Ok(())
Expand Down