Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #29
Similar to the 'load resources from disk' pull request and follows the same format.
@zizroc I think I've got something wonky with either my test csv or the way I'm loading values from it. If you get the chance can you see if anything jumps out (run the winik_manager test to see the errors)? I'm still a bit unsure about NULL vs NA. If you think that those NA's that I switched from NULL should go back to NULL let me know and I'll revert that change!
Also note that I didn't load any sort of children from the test winik file, or define any there. Since we're working with csv files, it's weird when you have to map a one->many relationship ie children->123, 543, 23 because the commas represent different columns. We could semi-colon separate the children so that the csv file is still valid-but I see that more of a hack than anything.
Right now, the winik-child relationships are like a doubly linked list. You can traverse from a child to a parent, or a parent to a child. We can get rid of the
children
list in the winik object and there's still the linking from a winik to its parent via the mother_id and father_id slots so we're not losing any information in doing so, and it keeps things a bit cleaner. But I'm pretty impartial. Any thoughts?