-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive searches break the modeline #40
Comments
After looking at this a bit, I've found that isearch handles this in the 'pre-command-hook. |
Thanks for reporting! |
If phi-seach is active, instead of erroring, what about just switching to the minibuffer? |
On 04/08/2015 02:23 PM, zk-phi wrote:
I was thinking more of: (when phi-search--active so that it just switches to the minibuffer and the old search continues. |
yes, I've just committed so please update |
On 04/08/2015 02:45 PM, zk-phi wrote:
Sorry I replied by mail and didn't see it. |
Another way to break the modeline is to execute another read-from-minibuffer call :/ I think read-from-minibuffer does a non-local exit in this case, which should be trapped with unwind-protect or condition-case. |
Assuming C-s is bound to phi-search:
C-s ; start phi-search
C-x o ; switch away
C-s ; break the modeline
I noticed that I got the modeline stuck with phi-search, and today I finally was able to realize how I did it ;). Isearch has quite a complex logic to determine when aborting search since it supports recursive searches, but the most interesting seem:
(add-hook 'mouse-leave-buffer-hook 'isearch-done)
(add-hook 'kbd-macro-termination-hook 'isearch-done)
I'm not sure if 'mouse-leave-buffer-hook is also run for C-x o?
The text was updated successfully, but these errors were encountered: