New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Overmixing In Edge cases #10462
Comments
So the issue here is: privacy is not gained despite coinjoining and these users are non-whales. |
Related: #10274 |
I see two issues here, The most concerning being the high fee, Privacy getting lost seems like it could be a temporary inclusion of new coins with denomination mismatch. It need fixing but shoudln't a few more remixes eventually increase privacy score? |
If only the transaction details had the decency of showing what we paid for between network fees vs coordinator fees maybe we'd have an easier way of finding the problem. |
Without digging into it, the network fees have to be taken into account as well. |
Little progress report: The high fee unfortunately is "normal" here and that's something we're constantly improving and there's a lot of room for improvement there. Privacy getting lost is what does not seem normal, but a bug. It'd be only normal if the users would be the largest participants in the rounds, but that's not the case. I took a look at the only modification we've done for the release: #10100 and it does not seem to be the culprit, because it barely affects anything and I tested against some wallets. |
Also leaving here @turbolay's ideas on improvements:
Some related improvements:
All this being said, the core of our algorithm: weighted average should be relaxed somehow based on the following insight:
|
Upon further investigation and testing there does not seem to be a bug here, rather these are random variations. Regardless I keep the issue open until a decent amount of already planned improvements as described in the previous message are done. |
Bummer... I don't find it acceptable to leave 8% of my stack on the table in fees for using the pleb mode of coinjoin pluggin |
… On Sat, Apr 15, 2023, 6:22 AM nopara73 ***@***.***> wrote:
@Kukks <https://github.com/Kukks> where should @strnly
<https://github.com/strnly> open an issue regarding BTCPay stuff?
—
Reply to this email directly, view it on GitHub
<#10462 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN357V6UBJNQNI7YEZ43QLXBIPBHANCNFSM6AAAAAAWXGMOPU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Pule08 What is the action item here? #10462 (comment) these ideas need to be implemented? |
Not implemented. They are very diverse things. One has already been implemented and merged, the other is waiting for review, another one requires surgical precision in backend coinjoin development, another one needs UX design first, so... it's complicated :) Maybe the best would be to create a different issue for every idea and close this one. |
This has been solved by the parts implemented here: #10708 (comment) |
Multiple users reported similar concerning issues:
The text was updated successfully, but these errors were encountered: