"Insufficient funds eligible for coinjoin" message is misleading/confusing when coins are unconfirmed

[Kruwed]

Discussed here - #8830 (comment)

Previously, the "Waiting for confirmed funds" message would appear in the music box in different cases

• When the user is receiving coins below their anon score target that are still in the mempool
• When the user has coins below their anon score target that are banned from registration

Now, the message has been changed to say "Insufficient funds eligible for coinjoin". While this more accurately describes the second case, it less accurately describes the first case. Instead of trying to come up with a single phrase that covers multiple scenarios, the better solution is to use a distinct message for each case ("Waiting for confirmed funds" and "Funds are ineligible for coinjoin") .

"Insufficient funds eligible for coinjoin" makes far less sense than "Waiting for confirmed funds" when the pending coin is actually unconfirmed and not banned. "Insufficient funds" misleads people into thinking there is a problem with the amount of BTC they have. The original instructions in the music box to "wait" is correct since the solution is to wait for the current transaction to confirm, not to send more unconfirmed funds.

I do agree that the "Waiting for confirmed funds" message appearing when inputs are banned makes no sense at all, but if the coinjoin isn't starting due to inputs being banned, that is when a message such as "Funds are ineligible for coinjoin" should appear.

If possible, it would help inform the user even more if the ban message in the musicbox would also show the countdown timer until they are unbanned since it is not easy to find the ban length from the UTXOs screen.

[MarnixCroes]

for new wallet creation UX it's definitly more confusing.
Create wallet -> deposit some corn -> "Insufficient funds eligible for coinjoin".
As a newbie user, this is a big question mark.
Waiting for confirmed funds is understandable for this

[turbolay]

If we are going to rollback this I believe it should be before the release, otherwise it would look ridiculous to change then rollback...

[yahiheb]

The decision to change Waiting for confirmed funds was made after a lot of user feedback and investigations and discussions:
#10313 (comment)
#10697 (comment)

Waiting for confirmed funds is understandable in one case but confusing in many other cases like when coins are banned, so reverting this is not an option because we know already it confused users:

https://github.com/search?q=repo%3AzkSNACKs%2FWalletWasabi+Waiting+for+confirmed+funds&type=issues
https://github.com/search?q=repo%3AzkSNACKs%2FWalletWasabi+Waiting+for+confirmed+funds&type=discussions
https://www.reddit.com/r/WasabiWallet/search/?q=Waiting%20for%20confirmed%20funds&restrict_sr=1&sort=new

[soosr]

I am planning to bring this topic up at a @zkSNACKs/ux-team meeting. Because I think what we did was not the best approach. I 100% agree that we should have as fewer messages as possible in the default music box workflow, but I also think we can have as many as we want for covering edge cases because they are not always there to cause confusion and actually they can describe better those cases which means less confusion.

With this most users would see very few messages in most cases, but we would also give clear explanations in rare edge cases if those happen.

[Kruwed]

On v2.0.4 RC1/Windows 10, I got the "Hurray! All your funds are private!" message while I had semi private coins that were still unconfirmed. Once the transaction confirmed, the message disappeared and the timer began again. The "Waiting for confirmed funds" message would be correct here instead:

I don't know if this step, is necessary to reproduce the Hurray! message, but it appeared after I clicked pause and play again while the "Successful coinjoin! Continuing..." message was still in the music box from the previous round.

Related? #9887

[yahiheb]

@Kruwed This seems to be a different one. Try to reproduce it again on master and if you can open an different issue for it.

[Kruwed]

Fixed by #11083