Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate OR color differentiate amounts in 3 digit chunks #2588

Open
MaxHillebrand opened this issue Nov 19, 2019 · 44 comments
Open

Separate OR color differentiate amounts in 3 digit chunks #2588

MaxHillebrand opened this issue Nov 19, 2019 · 44 comments

Comments

@MaxHillebrand
Copy link
Collaborator

MaxHillebrand commented Nov 19, 2019

Problem

Currently Wasabi shows the entire 8 digits behind the point in one blob, like 0.12345678. This makes it rather cumbersome to look for an exact amount, it's simply too many numbers in one place.

Solution

similar to #2118, separate the numbers after 4 digits, like 0.1234 5678, this increases readability greatly.

Alternative

Make the second chunk in a lighter grey, so it indicates that the first chunk is where the main value is.

@MaxHillebrand MaxHillebrand changed the title Separate amounts in 4 digit chungs Separate amounts in 4 digit chunks Nov 19, 2019
@Transisto
Copy link

Transisto commented Nov 19, 2019

I've never seen this done anywhere else to separate decimals.

I'm again't the idea, It would create awkwardness and confusion.

The reality is you can just look at first 5 decimal and the rest are barely worth a penny so they're not worth even looking at.

If there were to be a visual aid spacing standard, I'd make it simply be different shades digits

0.12345678 Last 4 digits being lighter.

@yahiheb
Copy link
Collaborator

yahiheb commented Nov 19, 2019

One thing is sure we can't have both separation and lighter digits.

@MaxHillebrand
Copy link
Collaborator Author

@yahiheb agreed, both would be redundant, and either does the job just fine - the goal is to make it easier to view which number is which digit behind the point - I'm not tied to either of the solutions.

@Transisto my idea of space separation is based on other data standards, like PGP finterprints or hex files or such. Yes, the incumbent math system might not use such - but we are in future cyberspace now, where old rules don't apply 😉

I would say, that adding a new color to the UI might make it more cluttered, which is something we try to reduce. By having it space separated, we can use the same color and font size with less clutter.

But we should also consider how much effort it is to implement, since this is rather a minor improvement. And here I really don't know exactly which of the two options would be more of a hassle, so that's for smarter people to decide.

@MaxHillebrand MaxHillebrand changed the title Separate amounts in 4 digit chunks Separate OR color differentiate amounts in 4 digit chunks Nov 20, 2019
@MaxHillebrand
Copy link
Collaborator Author

the screenshots here are very insightful in how some block explorers handle the topic. Most of them go for the color differential approach. One greys out only when it is a 0 at the end which I think is bad.

There is one who does space separation, but in 3 3 2 chunks, which I think is less pretty than 4 4 chunks.

@Transisto
Copy link

Transisto commented Nov 20, 2019

@Transisto my idea of space separation is based on other data standards, like PGP finterprints or hex files or such. Yes, the incumbent math system might not use such - but we are in future cyberspace now, where old rules don't apply 😉

The difference is those are string of relevant data, where a single wrong digit ruin the final outcome. Here we're talking about number precision.

When I see a 2nd blob of digit after the decimal place I think it's something else unrelated to the amount and I'm very confused.

The only one block explorer with space separation in Bitcoin.com, meaning it's most likely a bad idea, like almost everything they do. ;)

People are used to 3 decimals for large integers if a BTC could be divided to the 9th decimal it might make some sense to divide it up this way, (although it's still extremely uncommon and akward)

2 X 4 mean, it's a 2nd piece of data.

image

2nd or 3rd looks reasonable.
Using smaller font size is consistent with what those are; Less significant digits.

@MaxHillebrand
Copy link
Collaborator Author

After the dev-call and the chat here in the issue, I think we reached rough consensus on not separating by spaces, but instead using the slightly lighter color scheme. There's worry that decreasing the font size takes away the beautyfulness of the monospace alignment, but I guess that is to be seen in the final picture if implemented. There are some concerns that this will take a considerable amount of dev time and a bit hacky approach.

Ultimately this is not a priority issue, and there are more important tasks for the GUI devs.

@nopara73
Copy link
Contributor

I think it's more like a trial and error work than a specify upfront one, so let's not call it consensus just yet:)

@MaxHillebrand
Copy link
Collaborator Author

implemented

@Transisto
Copy link

Transisto commented Mar 12, 2022

Current implementation disregard everything we wrote.

The brain shouldn't be hurting from just looking at insignificant decimals.

@Transisto
Copy link

"After the dev-call and the chat here in the issue, I think we reached rough consensus on not separating by spaces, but instead using the slightly lighter color scheme."

What happened in the meantime?

@nopara73 nopara73 reopened this Nov 7, 2022
@Transisto
Copy link

Transisto commented Nov 8, 2022

image

Subtle, clean, effective.

@nopara73
Copy link
Contributor

nopara73 commented Nov 10, 2022

ACK. Added to backlog: https://github.com/orgs/zkSNACKs/projects/18/views/1

@MaxHillebrand
Copy link
Collaborator Author

fwiw, I start to think that XXX.XX XXX XXX is a better separation, as it makes thousands of sats more intuitive to see.

@Transisto
Copy link

Transisto commented Nov 14, 2022

Are there any other applications that split decimals with a space?

I thought maybe Geo coordinates,
I wasn't able to find one, and that's the problem.
Bitcoin is already akward enough for most people.

There is no problem separating sats in groups of 1000 but not the decimals.

There's a lot of other clunky things in this wallet, this is the first glaring one.

@MaxHillebrand
Copy link
Collaborator Author

@Transisto
Copy link

Transisto commented Nov 16, 2022

image
https://tradeblock.com/bitcoin

Stumbled on another implementation of dimmed decimals.

@yahiheb
Copy link
Collaborator

yahiheb commented Nov 16, 2022

From https://bitcoin.design/guide/designing-products/units-and-symbols/#current-adoption

This is very easy to read the sats amount with this separation:

home-unit-bitcoin@2x

formatting-elements@2x

@MaxHillebrand
Copy link
Collaborator Author

formatting-elements@2x

CACK, but I would not have the . for 1000 btc, instead a space

@Transisto
Copy link

I would reduce the space size so that it doesn't look like a 2nd column of numbers. Monospace makes the spacing too large.

While I'm sure a lot of thought has been put into that, nobody's yet using this format and I think we should focus on going to a stat standard. So IMO this whole dividing of 8 decimals into blocks of 3 and 2 should not be a priority.

@jmacato jmacato closed this as completed Jan 9, 2023
@sannydayX
Copy link

@yahiheb While it is indeed still a relevant issue, we need to sort out priorities first. There are too many issues opened atm and it is simply not efficient having so many issues open at the same time. Closing (or rather parking) it now, doesn't mean we won't do it.

There is no need to close issues/feature requests that are relevant, we should simply do better at prioritizing them and focus on working on what has been prioritized. Issues/PRs stay open for years everywhere on open source projects.

Yeah, I mean we just need to distinguish between "open topics" and "issues we are working on". I think this issue was (perhaps incorrectly) closed in an attempt to better organize, but we can find a way to do so without closing issues even when they are not ready for being closed.

@sannydayX
Copy link

People are now asking for multiple spacing options #9889

I've been following this topic from the beginning and here is the quick summary.

MaxHillebrand commented on Nov 21, 2019 After the dev-call and the chat here in the issue, I think we reached rough consensus on not separating by spaces, but instead using the slightly lighter color scheme.

Then someone implement decimal spacing. From my research, ANY spacing of decimals is extremely uncommon . People's brain simply see two columns of numbers every time they look at their wallet history and remain slightly annoyed.

There are now 1000x more people who are bothered with the two column than there are who cares about any of the alternatives types of spacing.

This improvement was discussed and resolved in 2019, A problem was implemented instead.

We have two choices, revert to 0.00000000 or implement what was agreed to in 2019 dev call. 0.00000000

I am voting for the no color distinction, since that is not that much better than the actual gap (only better from technical side, but for user it is the same).

@Kruwed
Copy link
Collaborator

Kruwed commented Jan 15, 2023

Fading or shrinking the last 4 digits makes less sense the smaller the amount being displayed is. Amounts under 10k sats would look like 0.0000xxxx where all of the zeros are in bold/big text while the actual information the user needs to know is grey or small.

@Transisto
Copy link

So far it seems like there's only a consensus that reverting it back to normal 8 decimal is better by default. If not only for the standard look of it.
Alternate views should could be added as options later on.

@yahiheb
Copy link
Collaborator

yahiheb commented Apr 12, 2023

Display amounts both in BTC and Sats denomination, as used by peachbitcoin:

https://mobile.twitter.com/BTCMentoring/status/1645531187799105536

image

@nostitos
Copy link

nostitos commented Apr 12, 2023

Display amounts both in BTC and Sats denomination, as used by peachbitcoin:

https://mobile.twitter.com/BTCMentoring/status/1645531187799105536

image

Notice too that the spacing between the 0s is smaller than a full character width.

Currently Wasabi amounts looks mentally like two numbers
image

@nopara73
Copy link
Contributor

This should get to the UX board.

@editwentyone
Copy link

editwentyone commented Apr 23, 2023

i would also like to throw in my 2 sats

🎨 Figma Link

  • i think to fully support every user, its also important to distinguish between american and european number format (comma and dot, dot and comma)
  • adding colour difference (alpha) for unused leading Zeros
  • changing roboto mono to roboto
  • only when the value goes to whale status, it makes sense to reduce trailing values to 2 digits (last 2 examples)

i also added that style to the history table (see figma), with just colour difference and mono font but also colour difference and regular font + 2% letter spacing

Bildschirmfoto 2023-04-23 um 16 43 36

@nopara73
Copy link
Contributor

Great! Everyone feel free to give your concept feedback, rather than after it's implemented!

I only have one thing to note:

i think to fully support every user, its also important to distinguish between american and european number format (comma and dot, dot and comma)

Wasabi is currently culture invariant. We're planning to briefly open this can of worms and reconsider this decision when we start working on localizations to different languages.

image

@nostitos
Copy link

nostitos commented Apr 24, 2023

@editwentyone

To simplify implementation
I don't think we should make a special case for that example of +300 billion $
If 9999.99999999 BTC fits then I think that's fine. "Whale" status starts way before that.
I also don't think it's worth having decimal separation at 10000 BTC. For such large amount it's not something anyone will ever be confused about.

So 1221.00 284 700

The most important part is that the spacing between decimals is much narrower than a character and your design seems to strike the right spacing.

@editwentyone
Copy link

Wasabi is currently culture invariant. We're planning to briefly open this can of worms and reconsider this decision when we start working on localizations to different languages.

thats ok, but it should be part of the localization, such details are the important ones when it comes to user experience and offload mental gymnastics by our users.

I don't think we should make a special case for that example of +300 billion $

sure that's ok. just wanted to cover also that case, just in case ;)

The most important part is that the spacing between decimals is much narrower than a character and your design seems to strike the right spacing.

intrestingly I did that with normal spaces, because Figma apparently doesn't support "thin space" unicode.
the main reason it looks differently is because its not a mono font anymore.

@MaxHillebrand
Copy link
Collaborator Author

Regarding localization, I don't think we have a problem here, because there's only the sub btc separator . and the decimal steps are a whitespace, this should be intuitive in any locale.

That's why I'm against showing . and , at the same time.

@editwentyone
Copy link

in Europe it should be 0,00 000 000 from the beginning.
in America its 0.00 000 000 at the same time.

also its $30,000.00 and 27.000,00€

that's already different, but its ok to stick with American one and redo this with localization.

@MaxHillebrand
Copy link
Collaborator Author

also its $30,000.00 and 27.000,00€

Here I disagree, it should just be $30 000.00 and 27 000,00€, this seems way less confusing.

@editwentyone
Copy link

editwentyone commented Apr 24, 2023

ok, but please only with the "thin space" not the "normal space".

its absolutely valid to separate with dot, comma and space. and I think its only confusing for people wandering between both worlds so frequently ;)

@nostitos
Copy link

nostitos commented Apr 30, 2023

The spacing better be very thin,
I've been using Trezor block explorer lately and looking at the numbers separated as 0.123 456 78 makes me fell dizzy. Wondering if it's the font or that the numbers are not just displayed as a simple lists.
https://btc1.trezor.io/tx/0e9de4278a9642aa9fc1a9d30efe18d0ae871bc3a99eb5654a0dd56b99d2cc31

image

@editwentyone
Copy link

true, the way trezor implemented it is really hard to consume.

@nopara73 nopara73 reopened this Jun 21, 2023
@MaxHillebrand MaxHillebrand changed the title Separate OR color differentiate amounts in 4 digit chunks Separate OR color differentiate amounts in 3 digit chunks Dec 27, 2023
@MaxHillebrand
Copy link
Collaborator Author

do it like this: https://mempool.space/tools/calculator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.