New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HWI to 2.2.1 #10185
Update HWI to 2.2.1 #10185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the DefaultResponseTests.cs do not pass.
For example HwiHelpTestAsync test fails with the following error:
HwiHelpTestAsync
Source: DefaultResponseTests.cs line 225
Duration: 1 min
Message:
Assert.Equal() Failure
Expected: 0
Actual: -1073741790
Stack Trace:
DefaultResponseTests.HwiHelpTestAsync() line 232
<>c.<ThrowAsync>b__128_0(Object state)
Also the TrezorTKataAsync test fails with the following error:
TrezorTKataAsync
Source: HwiKatas.cs line 32
Duration: 1 min
Message:
WalletWasabi.Hwi.Exceptions.HwiException : 'hwi enumerate' exited with incorrect exit code: -1073741790.
Stack Trace:
HwiClient.ThrowIfError(String responseString, IEnumerable`1 options, String arguments, Int32 exitCode) line 279
HwiClient.SendCommandAsync(IEnumerable`1 options, Nullable`1 command, String commandArguments, Boolean openConsole, CancellationToken cancel, Boolean isRecursion, Action`1 standardInputWriter) line 52
HwiClient.EnumerateAsync(CancellationToken cancel, Boolean isRecursion) line 255
HwiKatas.TrezorTKataAsync() line 49
--- End of stack trace from previous location ---
Is this critical for the next release? If yes please fix the issues @jmacato . |
@molnard no i dont think it's quite critical since it's only a patch release, i would like to merge this after this upcoming release window instead. |
I won't merge this before the release. Fixing the test will be required anyway so do not abandon this. 🙏 |
Keep up with this. Can someone go thought the Kata tests? |
Updated the firmwares of the Hardware wallets. (Only Ledgers had an update). Checked out this PR. Kata tests are passing. |
|
Waiting for @yahiheb approval.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
- Verified the signatures of the binaries.
- The TrezorTKataAsync test passes.
- The DefaultResponseTests.cs test pass.
https://github.com/bitcoin-core/HWI/releases/tag/2.2.1
Changelogs: