Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HWI to 2.2.1 #10185

Merged
merged 2 commits into from Apr 18, 2023
Merged

Update HWI to 2.2.1 #10185

merged 2 commits into from Apr 18, 2023

Conversation

jmacato
Copy link
Contributor

@jmacato jmacato commented Feb 24, 2023

https://github.com/bitcoin-core/HWI/releases/tag/2.2.1

Changelogs:

  • Signing of some P2SH multisigs with Trezor
  • Bumped typing-extensions version to 4.x
  • Pubkey serialization in ranged descriptors

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the DefaultResponseTests.cs do not pass.

For example HwiHelpTestAsync test fails with the following error:

 HwiHelpTestAsync
   Source: DefaultResponseTests.cs line 225
   Duration: 1 min

  Message: 
Assert.Equal() Failure
Expected: 0
Actual:   -1073741790

  Stack Trace: 
DefaultResponseTests.HwiHelpTestAsync() line 232
<>c.<ThrowAsync>b__128_0(Object state)

Also the TrezorTKataAsync test fails with the following error:

 TrezorTKataAsync
   Source: HwiKatas.cs line 32
   Duration: 1 min

  Message: 
WalletWasabi.Hwi.Exceptions.HwiException : 'hwi enumerate' exited with incorrect exit code: -1073741790.

  Stack Trace: 
HwiClient.ThrowIfError(String responseString, IEnumerable`1 options, String arguments, Int32 exitCode) line 279
HwiClient.SendCommandAsync(IEnumerable`1 options, Nullable`1 command, String commandArguments, Boolean openConsole, CancellationToken cancel, Boolean isRecursion, Action`1 standardInputWriter) line 52
HwiClient.EnumerateAsync(CancellationToken cancel, Boolean isRecursion) line 255
HwiKatas.TrezorTKataAsync() line 49
--- End of stack trace from previous location ---

@molnard molnard requested a review from Szpoti February 27, 2023 09:30
@molnard
Copy link
Collaborator

molnard commented Feb 27, 2023

Is this critical for the next release? If yes please fix the issues @jmacato .

@jmacato
Copy link
Contributor Author

jmacato commented Feb 28, 2023

@molnard no i dont think it's quite critical since it's only a patch release, i would like to merge this after this upcoming release window instead.

@molnard
Copy link
Collaborator

molnard commented Feb 28, 2023

I won't merge this before the release. Fixing the test will be required anyway so do not abandon this. 🙏

@molnard
Copy link
Collaborator

molnard commented Mar 24, 2023

Keep up with this. Can someone go thought the Kata tests?

@adamPetho
Copy link
Collaborator

Can someone go thought the Kata tests?

Updated the firmwares of the Hardware wallets. (Only Ledgers had an update).
Updated the Bitcoin App on the hardware wallets.

Checked out this PR.

Kata tests are passing.

@adamPetho
Copy link
Collaborator

Some of the DefaultResponseTests.cs do not pass.

For example HwiHelpTestAsync test fails with the following error:

DefaultResponseTests are also passing for me. @yahiheb could you re-test them?

@molnard
Copy link
Collaborator

molnard commented Mar 29, 2023

Waiting for @yahiheb approval....

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@molnard molnard merged commit 76ae3e9 into zkSNACKs:master Apr 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Not do
Development

Successfully merging this pull request may close these issues.

None yet

4 participants