Test vectors for v2.0.4 #10945
Comments
tACK
tACK
tACK
tACK 
tACK
tACK 
tACK 
tACK 
tACK
tACK
tACK
tACK
tACK
tACK
tACK
tACK
tACK, except for Search bar » Wallet section » Receive option » wording not changed still goes as "displays" instead of "display" both on the tooltip label. change request created by @MarnixCroes to fix it: #10983 
|
tACK 
tACK 
tACK
nACK still can repro: #10422 (comment)
nACK, space is still accepted 
|
How did you repro? I just tried on Mac and I can't either enter or paste a space. |
@turbolay paste |
tACK, 2 coins from reused address cannot be selected separately but together 10141_2.coins.from.reused.addredd.cannot.selected.separately.but.together.webm
tACK, see video in 10141
need another wallet to test is - will try later in the office
tACK 
tACK 9691_escape.goes.back_1.webm9691_escape.goes.back_2.webm
tACK 10430_tx.shield.fixed.webm
DO LATER - webcam needed
tACK
tACK
DO the test on Linux with webcam
tACK
tACK
|
tACK, shield icon is replaced by AS text in the column title 
nACK, Marnix created a comment: #10217 (comment)
tACK
nACK, to be fixed first: #10422
tACK nACK, #9952 - crash when sorting on labels: #11010
tACK 
tACK 
|
tACK
tACK
tACK
tACK
tACK
|
tACK, not relevant as it is outdated.
tACK
tACK
tACK 
tACK, QR code with CAPITAL uppercase
|
tACK
tACK
tACK
|
tACK 
@adamPetho please check it
|
Sorry @brizik but I only promised to go over the Hardware Wallet Kata tests yesterday. I can't go over all of this, I got other tasks to do. |
@adamPetho the other have been tested by me and @MarnixCroes this morning - all tACK. |
|
Turbosync
CoinJoin Multiple coinjoins, observer number of coins, cost, anonscore gains tACK |
Sorry then. I misunderstood your comment. 😅 All Kata tests are passing! |
What is this? Is it from #10512 @adamPetho ? The message “crash” is far from what we could call user-friendly. This issue about Test vectors is completely unreadable, I guess it would have been great to make use of Also, your nACKs have no explanations nor reproducing steps which make it hard to understand what exact scenario was tested to work on the result. The tests vectors themselves are too superficial and have all been done while merging the corresponding PR, I see really poor value in these test vectors. All the issues encountered were introduced by the decoupling or by rushed, not really tested features (like the privacy suggestions). For TurboSync, for example, you wrote nACK when the issue came from the privacy suggestion PRs. Encountering the problem was a side effect and luck, not thanks to the test vectors. BTW, it also shows how poorly these features were tested at the time of merging. Again for TurboSync, absolutely all the tests done were already covered by xUnit…….. IMO, our tests for the release have to go further than re-doing the basic tests developers make before merging, and instead test cross interactions between new components and changes. The AmountDecomposer changes are a good example here because they are both critical and hard to test. We tested them individually and incrementally, but now how do they really unfold with real rounds? We could invest time to have several daemons coinjoining, then analyze and draw conclusions from these datas. |
|
@turbolay I explicitly made sure to throw a dummy exception like this |
tACK 
|
|
Change HdPubKey Labels after Transaction is sent by Szpoti in #10397 need another wallet to test is - will try later in the office |
|
@molnard @MaxHillebrand
|
|
Awesome job @brizik and @MarnixCroes. @soosr can you take a look at the list and grab UI relateds? @brizik In the office I set up a windows / linux dual boot machine. Do you come to the office nowadays? |
UI
This was a false alarm. The issue is still fixed. They found a new one, which won't be fixed for the release.
Same for this, they found a new issue, won't be fixed for the release. #10994 (comment)
FTR the actual issue: #10985 |
Nope, but the PC will be. |
tACK. |
@MarnixCroes can you please check this one? |
I checked it quickly on the Linux test machine in the office and it works perfectly well. |
|
Dear Wasabikas, I'm thrilled to share that v2.0.4 has achieved a successful release, and I wanted to express my heartfelt gratitude for your exceptional testing efforts. Your meticulous testing, insightful feedback, and dedication to perfection have been instrumental in ensuring the high quality and functionality of our Wallet. Your contributions have made a significant impact, and we truly appreciate your commitment. Thank you once again for being an integral part of our success. Looking forward to more opportunities ahead! Best regards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test vectors
Coin control
Quit Wasabi
Send workflow
Music box
Recovery workflow
General
IndexStore. by kiminuo in Introduce sqlite for storing of filters forIndexStore. #10272Search bar
Crash report
Transaction details
Receive workflow
Wallet screen
Wasabi daemon
Hardware wallet
Turbosync
CoinJoin
Feebump RBF fee bump payment transactions #10805
Pirvacy warnings Alert users about risky spending behavior #8622
The text was updated successfully, but these errors were encountered: